-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple image upload #971
Multiple image upload #971
Conversation
animated | ||
value={this.state.imageUploadStatus.uploaded} | ||
max={this.state.imageUploadStatus.total} | ||
text={`${this.state.imageUploadStatus.uploaded}/${this.state.imageUploadStatus.total} files uploaded`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to add a translation for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a PR over on lemmy-translations for me to merge. Here's an example of using counts: https://github.com/LemmyNet/lemmy-translations/blob/main/translations/en.json#L148
You can grep the lemmy-ui for any of those formatted count type strings to see how to do in the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things, and the one i18n string to add. After the new string gets merged by me into lemmy-translations
, you can run:
git submodule update --remote
git add lemmy-translations
animated | ||
value={this.state.imageUploadStatus.uploaded} | ||
max={this.state.imageUploadStatus.total} | ||
text={`${this.state.imageUploadStatus.uploaded}/${this.state.imageUploadStatus.total} files uploaded`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a PR over on lemmy-translations for me to merge. Here's an example of using counts: https://github.com/LemmyNet/lemmy-translations/blob/main/translations/en.json#L148
You can grep the lemmy-ui for any of those formatted count type strings to see how to do in the UI.
Okay, now that the translations merged, you should just have to run:
|
Woodpecker is getting a build failure:
I don't know why it's doing this considering the code it's complaining about in the build isn't actually in the PR. This is what's actually in the PR's code. |
I pushed a small change an hour after the last one and the CI build worked this time. Disregard my last comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thx again!
This closes #777
This does what #812 by @sam365724 does but using the updated client.