Use zh-TW for language code, instead of zh_Hant. #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser never returns zh_Hant. Chinese language code is usually categorized according to geographical region. (zh-CN, zh-HK, zh-TW)
sonata-chen
changed the title
dessalines
requested changes
Jul 26, 2022
| @@ -63,7 +63,7 @@ export const languages = [ | |||
| { resource: sv, code: "sv", name: "Svenska" }, | |||
| { resource: vi, code: "vi", name: "Tiếng Việt" }, | |||
| { resource: zh, code: "zh", name: "中文 (简体)" }, | |||
| { resource: zh_Hant, code: "zh_Hant", name: "中文 (繁體)" }, | |||
| { resource: zh_Hant, code: "zh-TW", name: "中文 (繁體)" }, | |||
There was a problem hiding this comment.
Could you elaborate more why we must use an underscore here?
I have tested on my machine. It seems that it's not OK to use underscores for both zh_TW and pt_BR.
Lemmy (without a login) will not pick the correct language based on browser settings.
There was a problem hiding this comment.
my browser setting
navigator.languages: [ "zh-TW", "en-US", "en" ]
There was a problem hiding this comment.
Ah... I was under the impression it needed one, coulda swore I tested that with pt-BR. In that case I'll trust your judgement here, thx!
dessalines
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixed issue #667.