Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option types 2 #689

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Adding option types 2 #689

merged 4 commits into from
Jun 21, 2022

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Jun 21, 2022

This was a nightmare to do, and adds a ton of boilerplate to lemmy-js-client, but it does eliminate a whole class of null bugs typescript did their best to keep.

@dessalines dessalines requested a review from Nutomic June 21, 2022 17:33
@dessalines dessalines mentioned this pull request Jun 21, 2022
@dessalines dessalines merged commit d905c91 into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants