Post form community name using title instead of name #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested changes
Oct 29, 2021
| @@ -1462,7 +1462,7 @@ export const choicesConfig = { | |||
|
|
|||
| export function communitySelectName(cv: CommunityView): string { | |||
| return cv.community.local | |||
| ? cv.community.name | |||
| ? cv.community.title | |||
| : `${hostname(cv.community.actor_id)}/${cv.community.name}`; | |||
There was a problem hiding this comment.
The community title should also be used on this line too then.
I'm not sure if person select names should use the display name too if they have one set, but it makes sense to me that it should. Line 1471.
There was a problem hiding this comment.
Yeah, that makes sense, I also changed that.
There was a problem hiding this comment.
Yet another reason to hate typescript over rust. display_name unlike the community title is an optional field, so you need to check that it exists before you use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I deployed an instance in another language and found that when posting , the form comminity displays the community ID instead of its display name, but it's a bit inconvenient for non-native English instances, so I submitted the PR.
I can close this PR if you don't think you need it, and it will only work for my instance.
Thanks!