Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto download bug #2552

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix auto download bug #2552

merged 2 commits into from
Jun 17, 2024

Conversation

SleeplessOne1917
Copy link
Member

Fixes #2547

@SleeplessOne1917
Copy link
Member Author

I noticed that there's also no way to manually expand embedded videos. I'm wondering how that should be handled since embedded videos only show up when a URL is present, so the thumbnail is already being used for a link to the page.

@dessalines
Copy link
Member

The html video I think has a fullscreen button either by default or long-press on most browsers.

We could potentially use something like video.js for either this, or lemmy-ui-leptos, but IMO its just better to use the browser's own player.

@dessalines dessalines merged commit 4293c5a into main Jun 17, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the auto-download-bug branch June 18, 2024 00:19
@SleeplessOne1917
Copy link
Member Author

I'm not referring to a custom video player.

This is a post that just has a video as its URL:
Screencast_20240617_205159.webm
Notice that you can click on the icon thumbnail to show/hide the video.

Compare that to an embedded video:
Screencast_20240617_205222.webm
There's nowhere to click to show the video. Users who don't have auto-expand media turned on will have to follow the link to the page hosting the video if they want to see it.

@dessalines
Copy link
Member

dessalines commented Jun 18, 2024

That's a tough one... if we wanted to be consistent, I spose the video as url example, could not expand when auto_expand_media is false, but also open the url directly instead of embedding.

I'll re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Expand Media" with auto_expand_media off, and an embedded_url gives no way to embed in the page.
2 participants