Do most of the theme handling from the Theme component #2390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed some issues with the current way of handling themes:
This change moves all decisions about the current theme into the Theme component. The only thing outside of the Theme component is a script embedded in the SSR which sets the
data-bs-theme
attribute for "browser" and "browser-compact", as the server doesn't know the correct value and waiting for all scripts to load would be to slow. The Theme and Settings components communicate using"refresh-theme"
and"set-theme-override"
CustomEvent
s.Screenshots
Before
Code syntax highlight in wrong color scheme while loading
Live Preview
Screenshot made without saving the theme. Only "browser-compact" has problems after saving and reloading.
"browser-compact" live preview not compact
Live preview with mixed dark/light elements
Live preview "vaporwave-dark" in light
After
No screenshots. Things look as they should.