Lazy loading less common languages for syntax highlighting #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces client.js size by about 250kB (800kB uncompressed) Common languages: bash, c, cpp, csharp, css, diff, go, graphql, ini, java, javascript, json, kotlin, less, lua, makefile, markdown, objectivec, perl, php-template, php, plaintext, python-repl, python, r, ruby, rust, scss, shell, sql, swift, typescript, vbnet, wasm, xml, yaml Additionally enabled languages: dockerfile, pgsql
Allows to individually enable languages.
Allows to enable additional languages that will not be autodetected.
matc-pub
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
| readonly pending: Set<string>; | ||
| }; | ||
|
|
||
| "before:highlight"(context: { language: string }) { |
There was a problem hiding this comment.
You can name class methods with string literals?
webpack.config.js
Outdated
Comment on lines
7
to
8
| const { bundledSyntaxHighlighters } = require("./src/shared/build-config"); | ||
| const { lazySyntaxHighlighters } = require("./src/shared/build-config"); |
There was a problem hiding this comment.
If I'm not mistaken, this can be shortened to:
Suggested change
| const { bundledSyntaxHighlighters } = require("./src/shared/build-config"); | |
| const { lazySyntaxHighlighters } = require("./src/shared/build-config"); | |
| const { bundledSyntaxHighlighters, lazySyntaxHighlighters } = require("./src/shared/build-config"); |
SleeplessOne1917
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a plugin to highlight.js to detect when code should be highlighted using a language that is not yet loaded. A wrapped call to
md.renderprovides a callback that will be called after a language had to be loaded, this allows components toforceUpdate.Before
All available languages (listed here: https://highlightjs.org/download) are enabled and can be auto-detected.
After
Only the "common" set of 35 languages can be auto-detected, the remaining languages will be loaded individually on demand when explicitly specified by the author.
Uncommon languages, when auto-detected, are highlighted using the best fitting language of the common set.
client.jssize shrinks by about 240kB (compressed)