Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pnpm #2345

Merged
merged 14 commits into from
Jan 29, 2024
Merged

Move to pnpm #2345

merged 14 commits into from
Jan 29, 2024

Conversation

dessalines
Copy link
Member

Description

This moves from yarn to pnpm . Wasn't too difficult.

deploy.sh Outdated Show resolved Hide resolved
@dessalines dessalines enabled auto-merge (squash) January 29, 2024 03:07
@dessalines dessalines merged commit 140ff82 into main Jan 29, 2024
2 checks passed
@georgyo
Copy link

georgyo commented Jul 7, 2024

This change has made the nix packaging of lemmy much harder. Namely because Nix does not currently have a pnpm helper to fetch and build dependencies from the pnpm-lock.yaml. I am currently frozen on 0.19.3 because of this change. Looking at my federated instances, it seems like a great number of instances are still on 0.19.3 as well.

Something that was missing from this relatively major change in building was any reasoning for it. Was there something that pnpm provided that yarn did not? It's fine if there was some reasoning, but it would be nice if that was shared.

@dessalines
Copy link
Member Author

dessalines commented Jul 7, 2024

Much faster than yarn or npm, 2. Did you ask the nix devs why they don't support pnpm considering how much it is used in a lot of different node projects?

@georgyo
Copy link

georgyo commented Jul 7, 2024

They're working on it, I even linked to the ticket. There are existing solutions today for Nix pnpm, they are just complicated. Each of these package managers (npm, yarn, pnpm) have very different lock files. And then their lock file formats are changed pretty frequently as well.

BTW, for benchmarks listed in that 2nd link you listed, Yarn PNP wins nearly every race. Yarn even has the ability to use pnpm for the backend.

In any case, thanks for responding. I appreciate the work done on Lemmy. Just when I see major build system changes, it makes me curious as to why. Especially one that affects all downstream packaging and doesn't even make it into the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants