Adds a loading skeleton to posts, comments and trending communities #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-fm
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
SleeplessOne1917
requested changes
Jan 8, 2024
dessalines
reviewed
Jan 9, 2024
… css classes on the skeleton loading
dessalines
reviewed
Jan 11, 2024
SleeplessOne1917
requested changes
Jan 14, 2024
dessalines
reviewed
Jan 19, 2024
Co-authored-by: SleeplessOne1917 <[email protected]>
|
Hey, sorry for being away for almost 3 months. I've implemented the changes you asked, let me know if you have more requests or if the pull request can be merged. |
SleeplessOne1917
approved these changes
Mar 26, 2024
dessalines
requested changes
Mar 26, 2024
SleeplessOne1917
approved these changes
Mar 27, 2024
dessalines
approved these changes
Mar 27, 2024
auto-merge was automatically disabled
March 27, 2024 20:10
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't know if this PR fixes any open issues, but I thought that adding a loading skeleton would give a better look to the website.
Hope you guys like it.
Screenshots
Before
After
desktop-loading.mp4
mobile-loading.mp4