-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store volume level on window object #2307
Store volume level on window object #2307
Conversation
I'd suggest using |
I specifically did it this way so that the volume value starts muted in each session. However, if you suggest otherwise, I can do it with localStorage (or another global store if available). |
Alright I've changed it to work with localStorage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the changes requested from my other comments, please run prettier. It looks like some formatting changed.
I've checked it and event.target is undefined when used with |
Description
Currently every video starts muted. With this PR, the volume value is kept in the window and used while playing other videos.
componentDidMount is formatted
Husky auto formatting line 131 while commiting.