Fix dark theme highlight color for recent comments, restores colors to 0.18 values #2297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2264. Reverts changes from #2295.
Restores the background color for recent comments on dark themes to what they were in 0.18.
In the Darkly theme on 0.18, recent comments used to be light grey, then in 0.19 they became yellow. I think this was caused by an update of Bootstrap to v5.3.2, which added a default value for the dark theme
bs-highlight-bg
variable in bootstrap-utilities.css.The correct highlighted comment background colors were in the
:root, [data-bs-theme=light] { }
section of each theme, but not in the[data-bs-theme=dark] { }
section, so the values were getting overridden by Bootstrap's defaults. I copied thebs-highlight-bg
values into thetheme=dark
section for each of the dark theme CSS files.Edit: After learning more about Bootstrap I realized that the theme CSS files normally aren't edited manually and are instead compiled from the _variables .scss files. Not sure if it's a bug in Bootstrap that it goes with it's own dark theme defaults for this value. From reading the documentation on Bootstrap color modes, I think a fix is to set
$mark-bg-dark:
to the same value as$mark-bg:
in each of the dark theme scss files.Screenshots
Before
0.19.0
0.19.1
After