Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark theme highlight color for recent comments, restores colors to 0.18 values #2297

Merged
merged 11 commits into from
Dec 21, 2023

Conversation

Pseudochron
Copy link
Contributor

@Pseudochron Pseudochron commented Dec 20, 2023

Description

Fixes #2264. Reverts changes from #2295.

Restores the background color for recent comments on dark themes to what they were in 0.18.

In the Darkly theme on 0.18, recent comments used to be light grey, then in 0.19 they became yellow. I think this was caused by an update of Bootstrap to v5.3.2, which added a default value for the dark theme bs-highlight-bg variable in bootstrap-utilities.css.

The correct highlighted comment background colors were in the :root, [data-bs-theme=light] { } section of each theme, but not in the [data-bs-theme=dark] { } section, so the values were getting overridden by Bootstrap's defaults. I copied the bs-highlight-bg values into the theme=dark section for each of the dark theme CSS files.

Edit: After learning more about Bootstrap I realized that the theme CSS files normally aren't edited manually and are instead compiled from the _variables .scss files. Not sure if it's a bug in Bootstrap that it goes with it's own dark theme defaults for this value. From reading the documentation on Bootstrap color modes, I think a fix is to set $mark-bg-dark: to the same value as $mark-bg: in each of the dark theme scss files.

Screenshots

Before

0.19.0

lemmy0190

0.19.1

lemmy0191

After

lemmy0191 proposed

@SleeplessOne1917 SleeplessOne1917 merged commit ab74d3a into LemmyNet:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background color for new comments is too bright on darkly
2 participants