Attempting to fix SSR. #2243 #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
SleeplessOne1917,
alectrocute and
jsit
as code owners
dessalines
commented
Nov 28, 2023
| ); | ||
|
|
||
| const auth = req.headers.cookie | ||
| ? cookie.parse(req.headers.cookie).jwt | ||
| : undefined; | ||
|
|
||
| if (auth) { | ||
| client.setHeaders({ Authorization: `Bearer ${auth}` }); |
There was a problem hiding this comment.
This probably overwrote the setForwardedHeaders above.
SleeplessOne1917
approved these changes
Nov 29, 2023
|
Regarding cross-fetch: newer versions of node (I think 18 and above) include a fetch API that works the same as the browser one. |
|
Sweet. I'll start another lemmy-ui deploy for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying two different things to fix the SSR issue. But since I can't actually replicate the bug locally, these are just guesses.
cross-fetch. This seems to be abandoned, and everything appears to be working without it. I've also had some issues with it elsewhere.