use improved notification system for all notification types #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biosfood
force-pushed
the
main
branch
2 times, most recently
from
b8faf47 to
5b06e4a
Compare
biosfood
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
dessalines
reviewed
Oct 21, 2023
dessalines
reviewed
Oct 21, 2023
dessalines
approved these changes
Oct 22, 2023
…r when processing an application
SleeplessOne1917
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refresh the notification counts when marking a report or application as done as well.
Also prevent unneccesary refetching of unchanged notification counts (don't need to refetch reports when marking a PM as read)