Dont hide reply box on other actions. Fixes #1968 #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
SleeplessOne1917,
alectrocute and
jsit
as code owners
dessalines
commented
Oct 19, 2023
| res.data.comment_view, | ||
| s.commentsRes.data.comments, | ||
| ); | ||
| } |
There was a problem hiding this comment.
The main issue was on L1069 with s.finished.set
It should only "finish" the comment (IE clear the reply / edit box), on either an edit or a comment create. It shouldn't close the box on a vote, save, etc.
So I just had to create findAndUpdateCommentEdit alternatives that included the finished setting, and remove the finished on the existing ones.
SleeplessOne1917
approved these changes
Oct 19, 2023
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with comment actions "finishing" / closing the reply box
Screenshots
After
az_recorder_20231019_111528.mp4