-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move allowed and blocked instance tables to the column right of linked instance table #2071
Conversation
Looks better. Thoughts on tabs between the linked, blocked, and allowed instances to make it easier to get to the blocked ones as well? |
Hmm, tabs are not a bad option. I'll try it out and post a screenshot of it a bit later on. Or if you (@camporter) wanted to you could to! |
There's a |
Conserve some vertical space. And I assume linked instance list will usually belonger than allowed and blocked, combined or not.
bfbacd1
to
e22b020
Compare
As per suggestions from the initial PR. Using the suggested Tab component was implemented.
Will be weird if there are no instances linked on this instances page otherwise.
I think a max width for the table on screen sizes medium and above would be a good addition. The table looks a bit too spaced out in the screenshot. |
How about something like this? I wrapped the tabs and table in a Live version with these changes to try resizing |
To restrict the width of the table especially on wider screens
Description
Addresses #2065
I think for most instances, the linked instance list will be longer than the allowed and blocked list, combined or not. So it made sense to join the allowed and blocked instance tables into the same column, to the right of the linked instance table.
If there were blocked instances, they would be shown in another table below
Allowed Instances
.Screenshots
Before
After