Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move allowed and blocked instance tables to the column right of linked instance table #2071

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

dnswrsrx
Copy link
Contributor

Description

Addresses #2065

I think for most instances, the linked instance list will be longer than the allowed and blocked list, combined or not. So it made sense to join the allowed and blocked instance tables into the same column, to the right of the linked instance table.

If there were blocked instances, they would be shown in another table below Allowed Instances.

Screenshots

Before

before

After

After

@camporter
Copy link
Contributor

Looks better. Thoughts on tabs between the linked, blocked, and allowed instances to make it easier to get to the blocked ones as well?

@dnswrsrx
Copy link
Contributor Author

Hmm, tabs are not a bad option. I'll try it out and post a screenshot of it a bit later on. Or if you (@camporter) wanted to you could to!

@SleeplessOne1917
Copy link
Member

There's a Tabs component that's used in some other parts of the UI you can use if you're trying to add tabs.

Conserve some vertical space. And I assume linked instance list will
usually belonger than allowed and blocked, combined or not.
@dnswrsrx
Copy link
Contributor Author

A screenshot of the instances organised into tabs. I'm only showing the status tab if there are instances with that status. In this example, there are no blocked instances, so the Blocked Instances tab is not displayed.

Instances organised in tabs

As per suggestions from the initial PR. Using the suggested Tab
component was implemented.
Will be weird if there are no instances linked on this instances page
otherwise.
@SleeplessOne1917
Copy link
Member

I think a max width for the table on screen sizes medium and above would be a good addition. The table looks a bit too spaced out in the screenshot.

@dnswrsrx
Copy link
Contributor Author

How about something like this? I wrapped the tabs and table in a col-lg-8. On medium screen width and smaller, it'll take the full width. Otherwise it'll be restricted as per that column class.

Live version with these changes to try resizing

Screenshot 2023-08-29 at 12 11 28

To restrict the width of the table especially on wider screens
@SleeplessOne1917 SleeplessOne1917 merged commit acc32f2 into LemmyNet:main Aug 29, 2023
@dnswrsrx dnswrsrx deleted the instances-columns branch August 29, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants