Fixing comment report showing dot. #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
SleeplessOne1917,
alectrocute and
jsit
as code owners
|
I believe comment nodes were made lists/list items for accessibility purposes. You could probably preserve the list items while still fixing the issue by setting the the list decoration to none. |
|
Ah good call, found a better way to do it. |
SleeplessOne1917
approved these changes
Jul 26, 2023
dessalines
added a commit
that referenced
this pull request
Jul 26, 2023
* Fixing comment report showing dot. * Using list-unstyled instead of removing <ul and <li
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The comment report showed a dot because it was incorrectly a
<li>Screenshots
Before
After