Separate final comment row + add classes #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djvs
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
|
This one's been bugging me for a bit, no way to generically deal with the entire contents of a comment in CSS or JS without also including the footer with buttons. Think I meant to include this in my classes PR a little while back. |
SleeplessOne1917
approved these changes
Jul 25, 2023
dessalines
reviewed
Jul 25, 2023
| )} | ||
| <div className="d-flex justify-content-between justify-content-lg-start flex-wrap text-muted fw-bold"> | ||
| <> | ||
| <div className="comment-content"> |
There was a problem hiding this comment.
What's the point of these classes, that you didn't add? Why not use bootstrap classes?
I also don't see the before / after images.
There was a problem hiding this comment.
Oh nevermind this is for that weird styling thing people are trying to hack on to our bootstrap theme.
dessalines
approved these changes
Jul 25, 2023
dessalines
pushed a commit
that referenced
this pull request
Jul 25, 2023
Co-authored-by: djvs <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix for the comment HTML setup. Changes it from two wrapping divs (header, comment/edit + footer) to three (header, comment/edit, footer) and adds accompanying classes.
Screenshots
No change afaict. Checked locally.
Before
After