Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL/BIDI to post text #1963

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add RTL/BIDI to post text #1963

merged 1 commit into from
Oct 11, 2023

Conversation

hamidrezakp
Copy link
Contributor

Description

This PR will add Bi Directional text and RTL support to posts text.
However it will not fix comments text direction because the plugin I'm using markdown-it-bidi by @ahangarha doesn't support lists yet.

Partially fixes #347

Screenshots

Before

before

After

after

@ahangarha
Copy link

ahangarha commented Jul 20, 2023

A great step forward 👍🏾

Please make it WIP PR. Next week we can work together to fix the rest. For example, the comment form needs dir="auto" to the textarea.

We should fix the comments issue as well. It shouldn't be a big issue.

@hamidrezakp
Copy link
Contributor Author

A great step forward 👍🏾

Please make it WIP PR. Next week we can work together to fix the rest. For example, the comment form needs dir="auto" to the textarea.

We should fix the comments issue as well. It shouldn't be a big issue.

Thanks, sure, can't wait to have this feature merged.

@hamidrezakp hamidrezakp changed the title Add RTL/BIDI to post text [WIP] Add RTL/BIDI to post text Jul 20, 2023
@dessalines dessalines marked this pull request as draft July 20, 2023 17:36
@SleeplessOne1917 SleeplessOne1917 marked this pull request as ready for review July 20, 2023 22:23
@SleeplessOne1917 SleeplessOne1917 dismissed their stale review July 20, 2023 22:24

Didn't notice it was a draft

@SleeplessOne1917 SleeplessOne1917 marked this pull request as draft July 20, 2023 22:25
@hamidrezakp hamidrezakp mentioned this pull request Aug 6, 2023
3 tasks
@ahangarha
Copy link

Let's merge this PR as a partial fix. With the feedback we receive, we can move forward with more confidence.

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamidrezakp hamidrezakp marked this pull request as ready for review October 10, 2023 13:28
@hamidrezakp hamidrezakp changed the title [WIP] Add RTL/BIDI to post text Add RTL/BIDI to post text Oct 10, 2023
@dessalines dessalines merged commit f5780c2 into LemmyNet:main Oct 11, 2023
@ahangarha
Copy link

Thanks @hamidrezakp for taking the first step for adding bidi support.
I hope to see this on the public instances soon.

@hamidrezakp
Copy link
Contributor Author

Thanks @hamidrezakp for taking the first step for adding bidi support. I hope to see this on the public instances soon.

Thanks, yes i would love to see Lemmy fully bidirectional and available for all users.
And Thank you for writing markdown-it-bidi plugin. looking forward to see it support lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bidi / RTL support
4 participants