Use canonical URLs #1883
Merged
Use canonical URLs #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mminer237
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
Comment on lines
+470
to
+471
| this.context.router.route.match.url + | ||
| this.context.router.route.location.search |
There was a problem hiding this comment.
I thought url already contains the query params?
There was a problem hiding this comment.
I would have thought so from the name, but apparently not:
console.log(this.context.router.route);{
"location": {
"pathname": "/search",
"search": "?q=test&type=All&listingType=All&page=1&sort=TopAll",
"hash": "",
"state": null,
"key": "1hxl4e7m"
},
"match": {
"isExact": true,
"params": {},
"path": "/search",
"url": "/search"
}
}A separate change might want to change the OpenGraph URLs some places as it indeed always links without the query parameters.
SleeplessOne1917
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1418
This links each community, user profile, and post to the original instance it was made on as canonical. It also links comments to their posts as canonical, since that seems recommended and that's what reddit does. The only pages with query parameters included in the canonical URL are search pages since those are pretty inherent to the page's content and since that seems to be what other sites do.