Add show/hide button to password fields #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
requested review from
dessalines,
alectrocute and
jsit
as code owners
dessalines
reviewed
Jul 10, 2023
| type="button" | ||
| id={id} | ||
| onClick={linkEvent(this, handleToggleShow)} | ||
| aria-label={show ? "Hide Password" : "Show Password"} |
There was a problem hiding this comment.
Some of the strings in this file still need fixed.
dessalines
reviewed
Jul 12, 2023
| type="button" | ||
| id={id} | ||
| onClick={linkEvent(this, handleToggleShow)} | ||
| aria-label={show ? "Hide Password" : "Show Password"} |
There was a problem hiding this comment.
Some of the strings in this file still need fixed.
dessalines
approved these changes
Jul 14, 2023
dessalines
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Make working password inputs * Make show/hide password button use icon * Tweak look * Handle delete account form separately from change settings form * Adjust password strengthometer position * Incorporate PR feedback * Add translations
andrewstuart
pushed a commit
to andrewstuart/lemmy-ui
that referenced
this pull request
Jul 27, 2023
* Make working password inputs * Make show/hide password button use icon * Tweak look * Handle delete account form separately from change settings form * Adjust password strengthometer position * Incorporate PR feedback * Add translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives the user the ability to toggle the visibility of their password when using password input fields.
Screencast_20230707_191946.webm
Screenshots
With forgot password link
With password strengthometer
I also tweaked some parts of the settings page.
Before
After