Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-bs-theme #1810

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Fix data-bs-theme #1810

merged 6 commits into from
Jul 4, 2023

Conversation

SleeplessOne1917
Copy link
Member

Description

data-bs-theme wasn't being set as expected. This change should fix that.

@jsit
Copy link
Contributor

jsit commented Jul 4, 2023

Hm, it was working fine for me? Adding a prop to <App> feels odd to me.

@jsit
Copy link
Contributor

jsit commented Jul 4, 2023

Also thanks for grabbing those extra themes in the list, I thought I pushed that change but I guess it didn’t make it in.

@SleeplessOne1917
Copy link
Member Author

Hm, it was working fine for me?

When I test the latest changes locally, dark themes always have the upload button with light text on a light background.

Adding a prop to feels odd to me.

Agreed. This is a kludge. Even with this, it will only work after refreshing the page. We'll need to find a way to make sure the value that gets passed to data-bs-theme changes when the user changes.

@jsit
Copy link
Contributor

jsit commented Jul 4, 2023

Hm, it was working fine for me?

When I test the latest changes locally, dark themes always have the upload button with light text on a light background.

It works fine for me on page refresh.

@SleeplessOne1917
Copy link
Member Author

It works fine for me on page refresh.

@alectrocute @dessalines does it work for either of you?

@dessalines dessalines merged commit 322a44b into main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants