fix: Revert smaller text size #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsit
requested review from
dessalines,
SleeplessOne1917 and
alectrocute
as code owners
|
Looks good to me, though you should get some feedback from users on this one. |
alectrocute
approved these changes
Jul 4, 2023
SleeplessOne1917
approved these changes
Jul 4, 2023
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jul 4, 2023
…ocus-1772 * lemmy/main: (25 commits) v0.18.1-rc.10 Attempt to fix inability to logout from some instances (subdomains) (LemmyNet#1809) feat(theme): Vaporwave (LemmyNet#1682) fix: Revert smaller text size (LemmyNet#1795) Updated the regex for isAuthPath to reduce false positive hits (LemmyNet#1806) fix: Add focus border to markdown toolbar buttons fix: Add data-bs-theme attribute for user dark/light modes (LemmyNet#1782) v0.18.1-rc.9 fix: Fix comment collapse and vote buttons not having focus style (LemmyNet#1789) Add missing modlog reasons (LemmyNet#1787) Fix search page breaking on initial load when logged in (LemmyNet#1781) feat: Add PR template (LemmyNet#1785) v0.18.1-rc.8 Fix profile loading spinner fix: Break text on post titles so long words don't overflow fix: Move getRoleLabelPill to the only component that uses it fix: Remove unused hasBadges() function fix: Fix badge alignment and break out into component fix: Fix up filter row gaps and margins a little fix: Fix heading levels ...
hanubeki
referenced
this pull request
in hanubeki/hanubeki-lemmy-themes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Would like to hear some more feedback on this one.
#1591 reduced the base font size from 16px to 14px. Users have complained that this is too small.
Furthermore, this font size reduction was done on
$font-size-base, when it should have been done on$font-size-root.This PR unsets
$font-size-baseand changes$font-size-rootto93.75%. This makes body text 15px (andsmalltext13.125px), and also (by usingfont-size-rootinstead offont-size-base) results in more Bootstrap-adherent text size proportions.User and Community avatars (the small inline ones on posts) go from a height/width of 18.38px to 19.69px. A very small change but not nothing ¯_(ツ)_/¯
It might be worth considering unsetting
$font-size-rootentirely, so that body text is the browser default of16px; but15pxmight be a happy medium.Screenshots
Screenshots don't really adequately convey this change; best to try it out locally.
Before
After