Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix vote buttons not showing spinners while registering vote #1761 #1764

Merged
merged 2 commits into from
Jul 2, 2023
Merged

fix: Fix vote buttons not showing spinners while registering vote #1761 #1764

merged 2 commits into from
Jul 2, 2023

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jul 2, 2023

Fixes #1761

@dnswrsrx
Copy link
Contributor

dnswrsrx commented Jul 2, 2023

I see that componentWillReceiveProps has been made legacy. One of their suggestion is to use componentDidUpdate - would this lifecycle method work here?

@jsit
Copy link
Contributor Author

jsit commented Jul 2, 2023

@dnswrsrx

I see that componentWillReceiveProps has been made legacy. One of their suggestion is to use componentDidUpdate - would this lifecycle method work here?

lemmy-ui uses Inferno, not React: https://www.infernojs.org/docs/guides/components

@jsit jsit enabled auto-merge July 2, 2023 21:36
@jsit jsit merged commit 083d5aa into LemmyNet:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

@alectrocute alectrocute Awaiting requested review from alectrocute

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When voting your vote gets cleared leaving the impression it did not take
3 participants
@jsit @dnswrsrx @SleeplessOne1917