Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jwt cookie path #1741

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Fix jwt cookie path #1741

merged 1 commit into from
Jul 1, 2023

Conversation

sunaurus
Copy link
Collaborator

@sunaurus sunaurus commented Jul 1, 2023

Fixes #1740

alectrocute
alectrocute approved these changes Jul 1, 2023
View reviewed changes
Copy link
Contributor

@alectrocute alectrocute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good catch. We’ve had a lot of bugs come from this cookie refactor. Hopefully this is the last of it.

@sunaurus sunaurus mentioned this pull request Jul 1, 2023
Closed
4 tasks
@SleeplessOne1917 SleeplessOne1917 merged commit f87dad3 into LemmyNet:main Jul 1, 2023
@sunaurus sunaurus deleted the cookie_path branch July 2, 2023 00:07
@diamondburned
Copy link
Contributor

diamondburned commented Jul 2, 2023 •
edited
Loading

Sorry, my bad... I thought I had the path...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alectrocute alectrocute alectrocute approved these changes

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

@jsit jsit Awaiting requested review from jsit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookies set during login are set too specific causing it to break
4 participants
@sunaurus @diamondburned @SleeplessOne1917 @alectrocute