Fix PostListing mobile margin layout issue
#1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
SleeplessOne1917
requested changes
Jun 29, 2023
| @@ -1373,7 +1373,7 @@ export class PostListing extends Component<PostListingProps, PostListingState> { | |||
| <div className="d-block d-sm-none"> | |||
| <article className="row post-container"> | |||
| <div className="col-12"> | |||
| {this.createdLine()} | |||
| <div className="mb-1">{this.createdLine()}</div> | |||
There was a problem hiding this comment.
this.createdLine already returns a div. Put the class name on that instead of making a new div.
There was a problem hiding this comment.
But I want it to only affect mobile. Any ideas how to do that?
There was a problem hiding this comment.
I can add an arg to createdLine, actually.
There was a problem hiding this comment.
I believe you can use mb-1 mb-md-0. At least, I think margin classes are responsive.
There was a problem hiding this comment.
That totally did the trick. Thanks so much.
There was a problem hiding this comment.
Always look for Bootstrap classes before adding a element or a div
|
@SleeplessOne1917 Please check out my latest commit. Thanks! |
SleeplessOne1917
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
In this PR:
PostListingmobile margin layout issueOn mobile, the avatar of the user on the
createdLinewas touching the title of the post. It was bugging me. This fixes it.Thanks!