-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add user action buttons to post dropdown #1653 #1655
Merged
dessalines
merged 14 commits into
LemmyNet:main
from
jsit:fix/put-user-action-buttons-in-dropdown-1653
Jun 29, 2023
Merged
fix: Add user action buttons to post dropdown #1653 #1655
dessalines
merged 14 commits into
LemmyNet:main
from
jsit:fix/put-user-action-buttons-in-dropdown-1653
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsit
requested review from
dessalines,
SleeplessOne1917 and
alectrocute
as code owners
June 27, 2023 23:47
@alectrocute Are you still not seeing them? You should now. |
dessalines
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much better.
One thing: add the capitalizeFirstLetter
to ban_from_community
SleeplessOne1917
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1653
All the "user action" buttons are now in the dropdown, and all the confirmation dialogs for these actions show up in the
removeAndBanDialogs
area.They could definitely stand to be sorted differently; currently they are sorted by the permissions required to show them, but it means that a lot of "postive" actions are next to "negative" actions, and a lot of "post-level" actions are next to "person-level" actions.
I started to reorganize these and then realized the permissions are really fragile and important not to screw up, so I didn't.
What's left is just the moving of everything into the right places without a difficult to read PR.
The dialogs need a ton of work -- for instance, here's all you see after clicking "transfer community":
But this PR should fix the bug of these items being really hard to even access since they were behind a dropdown.