Fix borders on MarkdownTextarea buttons when disabled
#1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines,
SleeplessOne1917 and
jsit
as code owners
|
Haha, @SleeplessOne1917 looks like we accomplished the same issue within a minute of eachother. |
SleeplessOne1917
approved these changes
Jun 27, 2023
jsit
reviewed
Jun 27, 2023
| @@ -159,13 +159,16 @@ export class MarkdownTextArea extends Component< | |||
| <div className="mb-3 row"> | |||
| <div className="col-12"> | |||
| <div className="rounded bg-light border"> | |||
| <div className="d-flex flex-wrap border-bottom"> | |||
| <div | |||
| className={`d-flex flex-wrap border-bottom ${ | |||
There was a problem hiding this comment.
This should be done with classnames:
className={classNames("d-flex flex-wrap border-bottom", {
"no-click": this.isDisabled,
})}There was a problem hiding this comment.
I’ll make another PR.
SleeplessOne1917
added a commit
that referenced
this pull request
Jun 27, 2023
Use `classNames` in #1650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lemdevs!
In this PR:
MarkdownTextareabuttons whenprops.isDisabled.Before:
After:
Thanks!