feat(UI): Make post listing (icon) avatars smaller (line-height) #1597
Conversation
jsit
requested review from
dessalines,
SleeplessOne1917 and
alectrocute
as code owners
|
@alectrocute @SleeplessOne1917 This feels like a relatively large decision, should we wait for @dessalines to weigh in? |
Yep, let’s do. |
…istings * lemmy/main: feat(UI): Fix some link hover colors
|
I'm going to dissent and say I don't like it too much. What I discovered in playing around with this in jerboa, was that the icon size was actually more important in making things look cleaner: Right now, they're wayy too big in lemmy-ui. In jerboa they're properly sized to the text, and it makes a lot of difference. post list-view:
post card-view:
And it smartly hides the community icon on the community page. The other thing is that icons, even if they're tiny, really help with instant recognition of users and communities. When you have icons in one place but not the other, its throws that off. |
|
@dessalines I hear you -- glad to have gotten your feedback on this before merging. Would it be a welcome PR to make them a little smaller in the post list view? |
We should definitely at least make the avatars line-height IMO. |
|
@jsit it'd be a good idea to make them match the text line height closely everywhere (except the tops of the profile and community pages). |
|
@alectrocute @dessalines I've restored the icon size, and made the height/width equal to one line height. Updated screenshots in description. |
jsit
changed the title
|
@SleeplessOne1917 Oops you're right, I forgot to push. Should be good now. |
|
Super excited for this PR. Thanks @jsit |
Need opinions on this. This will reduce some visual noise and also tighten things up vertically a little.
Before
After