Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search request being called twice on search page #1589

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Fix search request being called twice on search page #1589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25cab15
Fix search request being called twice on search page
SleeplessOne1917 Jun 25, 2023
9f6b48c
Merge branch 'main' into double-search
alectrocute Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/shared/components/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,9 @@ export class Search extends Component<any, SearchState> {
}

async componentDidMount() {
if (!this.state.isIsomorphic) {
if (
!(this.state.isIsomorphic || this.props.history.location.state?.searched)
) {
const promises = [this.fetchCommunities()];
if (this.state.searchText) {
promises.push(this.search());
Expand Down Expand Up @@ -1095,7 +1097,9 @@ export class Search extends Component<any, SearchState> {
sort: sort ?? urlSort,
};

this.props.history.push(`/search${getQueryString(queryParams)}`);
this.props.history.push(`/search${getQueryString(queryParams)}`, {
searched: true,
});

await this.search();
}
Expand Down