Cache post listings and restore listing state when using browser back navigation buttons. #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… navigation buttons.
dudeami0
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
SleeplessOne1917
approved these changes
Jun 23, 2023
4 tasks
|
Hm it seems like this might have been some cached JS for me — tried it again and it worked. Will keep an eye on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution to #1520, on loading post listings the
RequestState<GetPostsResponse>is cached. When navigating away from the home page followed by using the browser navigation back button, the cache is used to restore the post listings to the state the user left it in.