Fix server-side rendering after first load. #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudeami0
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
| @@ -67,7 +68,7 @@ export class Communities extends Component<any, CommunitiesState> { | |||
| this.handleListingTypeChange = this.handleListingTypeChange.bind(this); | |||
|
|
|||
| // Only fetch the data if coming from another route | |||
| if (FirstLoadService.isFirstLoad) { | |||
| if (!isBrowser() || FirstLoadService.isFirstLoad) { | |||
There was a problem hiding this comment.
If everywhere isFirstLoad is used needs to be ORed with !isBrowser(), it's easier to move that logic to the isFirstLoad function.
There was a problem hiding this comment.
I was hesitant to change the functionality of isFirstLoad in the case it was used for server initialization. If isFirstLoad is assumed to be browser first load I'll move the check there.
SleeplessOne1917
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side rendering was being disabled by the global variable
FirstLoadService.isFirstLoadbeing set on the server side tofalseafter the first page was rendered. This commit adds a check for if!isBrowser()so server side rendering is triggered on every page request. This was preventing Open Graph meta tags and other metadata from being generated.