Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inability to navigate to Home from Settings routes #1506

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix inability to navigate to Home from Settings routes #1506

merged 2 commits into from
Jun 23, 2023

Conversation

alectrocute
Copy link
Contributor

@alectrocute alectrocute commented Jun 23, 2023 •
edited
Loading

Hi Lemmiaires.

In this PR:

  • Fix inability to navigate to Home from Settings route, and probably other routes, too.
  • Optional chaining resolves it
  • Uh... don't know why TypeScript doesn't catch this
Screen.Recording.2023-06-22.at.9.37.43.PM.mov

Thanks.

@alectrocute
Copy link
Contributor Author

Steps to reproduce:

  • Go to https://lemmy.ml/settings directly
  • Click on the top left site header
  • Observe page break
  • Click again, observe CSS go away (of course)
Screenshot 2023-06-22 at 9 45 41 PM

@alectrocute alectrocute enabled auto-merge (squash) June 23, 2023 02:01
@alectrocute alectrocute merged commit d127b56 into LemmyNet:main Jun 23, 2023
@alectrocute alectrocute deleted the fix-settings-to-home-issue branch June 23, 2023 03:29
@alectrocute alectrocute mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

@jsit jsit Awaiting requested review from jsit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alectrocute @SleeplessOne1917