Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix post creator text alignment #1373

Merged
merged 6 commits into from
Jun 19, 2023
Merged

fix: Fix post creator text alignment #1373

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90cd24b
fix: Fix post creator text alignment
jsit Jun 18, 2023
87350bd
chore: Empty commit to retrigger Woodpecker job
jsit Jun 18, 2023
b55cf01
Merge remote-tracking branch 'origin/main' into fix/fix-post-creator-…
jsit Jun 19, 2023
ad984c8
fix: Use classnames
jsit Jun 19, 2023
edf13f3
Merge branch 'main' into fix/fix-post-creator-alignment
SleeplessOne1917 Jun 19, 2023
2348bbb
Merge branch 'main' into fix/fix-post-creator-alignment
jsit Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/shared/components/person/person-listing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,19 @@ export class PersonListing extends Component<PersonListingProps, any> {
{!this.props.realLink ? (
<Link
title={apubName}
className={this.props.muted ? "text-muted" : "text-info"}
className={`d-inline-flex align-items-baseline ${
this.props.muted ? "text-muted" : "text-info"
}`}
to={link}
>
{this.avatarAndName(displayName)}
</Link>
) : (
<a
title={apubName}
className={this.props.muted ? "text-muted" : "text-info"}
className={`d-inline-flex align-items-baseline ${
this.props.muted ? "text-muted" : "text-info"
}`}
href={link}
rel={relTags}
>
Expand Down
8 changes: 4 additions & 4 deletions src/shared/components/post/post-listing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,10 @@ export class PostListing extends Component<PostListingProps, PostListingState> {
</span>
)}
{this.props.showCommunity && (
<span>
<span className="mx-1"> {i18n.t("to")} </span>
<CommunityLink community={post_view.community} />
</span>
<>
{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the space necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unfortunately, otherwise these elements cram together:

Screenshot 2023-06-18 at 11 21 26 PM

{i18n.t("to")} <CommunityLink community={post_view.community} />
</>
)}
</li>
{post_view.post.language_id !== 0 && (
Expand Down