feat(post): Move post domain beneath post title #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-beneath-title * origin/main: Always allow users to control whether they see NSFW content fix: Fix display inline of post title fix: Use btn-sm for advanced menu dropdown buttons fix: Remove some extra classes on flag/report buttons fix: Fix vertical alignment and border radius of advanced dropdown menu items fix(a11y): Add aria-controls for advanced button dropdown fix: Fix some button labels and tippy text Empty commit to re-trigger Woodpecker job fix: Remove unused var feat: Move advanced post menu into dropdown fix: Only post title should be inside h5, not the additional metadata icons
|
It would be more intuitive if the preview button's behavior swapped with the thumbnail's behavior:
This would solve #1142 and #634 If you don't think this should be addressed in this PR, I will start a new issue |
|
@glibg10b Hm yeah I think this is a change in behavior that's outside the scope of this PR. Thank you though! Though I will say that link posts that have thumbnails have both (a) expandable images and (b) expandable text. This is from beehaw.org which I think runs 0.17.4: 
|
jsit
changed the title
…here is something to show; add 'active' color
jsit
changed the title
jsit
changed the title
…-beneath-title * origin/main: fix(post): Fix missing labels on block/report buttons in new dropdown fix: Add compiled theme stylesheets fix: Fix too-intense hr color between posts fix: Prettier ignore generated themes, as they aren't written by humans feat: Badge-ify NSFW and removed by mod title info
…-beneath-title * origin/main: fix: Use classnames chore: Empty commit to retrigger Woodpecker job fix: Fix post creator text alignment
dessalines
approved these changes
Jun 19, 2023
| @@ -84,10 +84,6 @@ | |||
| margin-top: -6.5px; | |||
| } | |||
|
|
|||
| .post-title { | |||
| line-height: 1; | |||
| } | |||
There was a problem hiding this comment.
Thanks. Every bit of custom css we can remove is a win.
jsit
added a commit
to jsit/lemmy-ui
that referenced
this pull request
Jun 19, 2023
* origin/main: v0.18.0-rc.2 feat(post): Move post domain beneath post title (LemmyNet#1363) Updated link to lemmy-repo as direct link to issues Changed text in feature request template feat(css): make vertical rhythm more consistent for post listings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some design work here, trying to tidy up all the metadata grouped together in the post details.
I've moved the link domain and the "expand" button to beneath the post title in small text. I think this makes it easier to parse the information.
Before
After