chore: Theme sass cleanup #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: Revert "fix: Sass files don't need to refer to full node_modules path"
fheft
reviewed
Jun 17, 2023
There was a problem hiding this comment.
Thanks, a clean-up is very much needed, as I omitted that in my last branch and even made the redundant variable situation worse (to get it working in the first place...).
Some buttons turned from "pill" to "chiclet" style, I think because the themes hadn't been rebuilt in a bit (
yarn themes:build).
There should actually be no changes though (i.e. identical CSS files), because the themes were build very recently (#1246). Maybe it has something to do with the (not working) overrides?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After (should look identical)