Add default profile picture for users who do not set one #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,16 +107,6 @@ export class PersonDetails extends Component<PersonDetailsProps, any> { | |||
| setupTippy(); | |||
| } | |||
|
|
|||
| // TODO wut? | |||
There was a problem hiding this comment.
This was 3 years old, commented out, and I have not idea what to make of "TODO wut?" so I removed it.
dessalines
approved these changes
Jun 17, 2023
|
I haven't been a big fan of slamming in pfps where people don't set them, but if enough people want them to make things line up better, I'm not opposed. |
|
@dessalines There was a discussion about this in the dev channel. Do you think gravatars might be a better approach? |
|
Something like gravatars would be pretty cool to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1162. Unsure if I should open a separate issue for allowing instance admins to set their own default profile picture if they want.
Here is a post made by a user with a default pfp.
