Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move text formatting bar above textarea #1334

Merged
merged 6 commits into from
Jun 17, 2023

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jun 16, 2023

Move test formatting bar above textarea, as per this comment: #1288 (comment)

Note that this does this everywhere there is a markdown textarea, including in creating new posts, editing your bio, etc.

Also fixes:

  • Create a "box" around the whoel markdown textarea/formatting bar so it's clear what you're formatting
  • The "Post" button had a margin-right, not a margin-left as it should have
  • Applied stylelint rules
  • Fixed .emoji-picker selector
  • Remove odd "button"-style formatting from language dropdown and its odd fixed/auto width behavior
Screenshot 2023-06-16 at 8 02 22 PM Screenshot 2023-06-16 at 7 45 38 PM Screenshot 2023-06-16 at 7 45 31 PM Screenshot 2023-06-16 at 7 45 26 PM

@alectrocute
Copy link
Contributor

alectrocute commented Jun 16, 2023

This may be a nitpick, but non-comment-related use cases, when the buttons are on top, it becomes confusing if there’s another input field nearby.

It would be great to have this functionality controlled by a prop so we can use the bottom’d version in the non-comment-related use cases.

@jsit
Copy link
Contributor Author

jsit commented Jun 16, 2023

@alectrocute I agree. Not sure if adding a top/bottom switch prop is the right solution, or if it just needs a little design work to make the connection more clear.

@SleeplessOne1917
Copy link
Member

@jsit my gut is leaning towards the latter.

@alectrocute
Copy link
Contributor

alectrocute commented Jun 16, 2023

@alectrocute I agree. Not sure if adding a top/bottom switch prop is the right solution, or if it just needs a little design work to make the connection more clear.

@jsit my gut is leaning towards the latter.

I think either would work! 😄 I'll never disapprove of making the markdown textarea better-looking & more unified.

@jsit
Copy link
Contributor Author

jsit commented Jun 17, 2023

@alectrocute @SleeplessOne1917

I did some design work here:

Screenshot 2023-06-16 at 7 45 26 PM Screenshot 2023-06-16 at 7 45 31 PM Screenshot 2023-06-16 at 7 45 38 PM Screenshot 2023-06-16 at 8 02 22 PM

@alectrocute
Copy link
Contributor

Other than the top border-radius of the text area (noticeable in dark theme), looks great IMO!

@jsit
Copy link
Contributor Author

jsit commented Jun 17, 2023

Other than the top border-radius of the text area (noticeable in dark theme), looks great IMO!

Good call, just fixed that, thanks.

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SleeplessOne1917 SleeplessOne1917 merged commit 19b3de1 into LemmyNet:main Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants