-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move text formatting bar above textarea #1334
feat: Move text formatting bar above textarea #1334
Conversation
This may be a nitpick, but non-comment-related use cases, when the buttons are on top, it becomes confusing if there’s another input field nearby. It would be great to have this functionality controlled by a prop so we can use the bottom’d version in the non-comment-related use cases. |
@alectrocute I agree. Not sure if adding a top/bottom switch prop is the right solution, or if it just needs a little design work to make the connection more clear. |
@jsit my gut is leaning towards the latter. |
I think either would work! 😄 I'll never disapprove of making the markdown textarea better-looking & more unified. |
@alectrocute @SleeplessOne1917 I did some design work here: ![]() ![]() ![]() ![]() |
Other than the top border-radius of the text area (noticeable in dark theme), looks great IMO! |
Good call, just fixed that, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Move test formatting bar above textarea, as per this comment: #1288 (comment)
Note that this does this everywhere there is a markdown textarea, including in creating new posts, editing your bio, etc.
Also fixes:
.emoji-picker
selector