Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to previous page after login #1309

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

alectrocute
Copy link
Contributor

@alectrocute alectrocute commented Jun 15, 2023

Hey everybody! Proposal:

Also included bugfix:

  • Fix a bug, a pretty bad one, that became very noticeable while testing this feature. It prevents the user from navigating to / from /login, if /login is the first loaded page in that browser tab. I don't know if this is reported. Checking if this.isoData.routeData.length is falsey and some optional chaining fixes this right up. This only affects >= 0.18 and seems to be related to the HTTP migration.
bug.mov

Reproduction steps:

  • Open Incognito window to <localhost:1234>/login
  • Click on main title on navbar, or login, to navigate to /.
  • Notice the page doesn't change and error occurs in console.

@SleeplessOne1917 SleeplessOne1917 merged commit 9d91b6a into LemmyNet:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When you log in, it kicks you back into the front page, losing where you were and disorienting the user
2 participants