Go back to previous page after login #1309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everybody! Proposal:
history.action
isPUSH
(eg. there's some Lemmy page to go back to) and if so, use History API to goback()
upon successful login. This will resolve When you log in, it kicks you back into the front page, losing where you were and disorienting the user #1268.Also included bugfix:
/
from/login
, if/login
is the first loaded page in that browser tab. I don't know if this is reported. Checking ifthis.isoData.routeData.length
is falsey and some optional chaining fixes this right up. This only affects>= 0.18
and seems to be related to the HTTP migration.bug.mov
Reproduction steps:
<localhost:1234>/login
/
.