Remove pictrsDeleteToast usage from PostForm
#1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fix infinite loading bug if upload error occured
alectrocute
requested review from
dessalines and
SleeplessOne1917
as code owners
alectrocute
commented
Jun 14, 2023
| } else { | ||
| toast(JSON.stringify(res), "danger"); | ||
| } | ||
| } else if (res.state === "failed") { | ||
| console.error(res.msg); | ||
| toast(res.msg, "danger"); | ||
| i.setState({ imageLoading: false }); |
There was a problem hiding this comment.
Caught an infinite loading bug here, this resolves it.
alectrocute
commented
Jun 14, 2023
| form: { | ||
| url, | ||
| }, | ||
| imageDeleteUrl: "", |
There was a problem hiding this comment.
If form.url is changed, we can assume user wants to abandon image – so imageDeleteUrl should be cleared.
alectrocute
commented
Jun 14, 2023
| imageDeleteUrl: "", | ||
| imageLoading: false, | ||
| form: { | ||
| url: "", |
There was a problem hiding this comment.
Clearing the form.url is important here to remove the now-deleted image.
alectrocute
changed the title
pictrsDeleteToast(...) usage from PostForm, handle delete_url in state, add buttonpictrsDeleteToast usage from PostForm
…ithub.com/alectrocute/lemmy-ui into AA/remove-pictrsdeletetoast-from-postform
alectrocute
commented
Jun 14, 2023
| @@ -269,6 +270,17 @@ export class PostForm extends Component<PostFormProps, PostFormState> { | |||
| {url && isImage(url) && ( | |||
| <img src={url} className="img-fluid" alt="" /> | |||
| )} | |||
| {this.state.imageDeleteUrl && ( | |||
There was a problem hiding this comment.
Using this.state.imageDeleteUrl for visibility of this button ensures it only appears alongside uploaded images. It's cleared upon change of form.url, so should be safe.
SleeplessOne1917
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores an uploaded image's
delete_urlin state instead and makes visible a "delete" button which fetches thedelete_urland removes the image/url. Also fixes infinite loading bug as mentioned in this PR's comments. Resolves #1255.Future thought: It would be really nice to move away from
pictrsDeleteToastentirely.EmojisFormis an easy candidate for a similar treatment to this PR. We'll need to add some more complicated functionality/UI for multiple image uploads, like inMarkdownTextarea, so maybe let's save that for last. 😅Thanks, Lemmy team!