Left-align comment collapse/expand button #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines and
SleeplessOne1917
as code owners
| aria-label={this.expandText} | ||
| data-tippy-content={this.expandText} | ||
| > | ||
| {this.state.collapsed ? ( |
There was a problem hiding this comment.
While it was like this before your PR, it could be nice to rewrite lines 243-247 as:
<Icon icon={`${this.state.collapsed ? "plus" : "minus"}-square`} classes="icon-inline" />There was a problem hiding this comment.
Ah, yes. Good suggestion, I'll push the change.
…ectrocute/lemmy-ui into collapse-expand-align-comment
SleeplessOne1917
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Here's a quick PR to left-align the collapse/expand button on comment nodes.
This is a pain point especially noticeable on mobile, when collapsing comments –different username lengths lead to the button being at different locations– forcing the user to hunt for the collapse button. It's very fatiguing. Having it left-aligned keeps it in the same place regardless of the other dynamic element widths.
Thanks so much!