Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the community title in the sidebar link to the local community. #1161

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

camporter
Copy link
Contributor

  • Makes it so that the LEMMY_UI_DEBUG flag toggles depending on its value, rather than its presence.
  • Makes the community title into a link that goes to the local community.

The existing link to the non-local community right below the title is not as helpful as the local community link, because the user likely wants to go to the community within the instance they are on.

Feel free to close or redo, thanks!

@SleeplessOne1917
Copy link
Member

I'm not quite sure what the point of this is. Why would you need a link to a community when you're already viewing a community?

@camporter
Copy link
Contributor Author

camporter commented Jun 11, 2023

Mostly for when viewing posts and needing to get back to the community from a search or other place. Right now, there's a smaller link to the community on the local instance. And in the sidebar, if the community is remote a link, there's only a link to the remote community.

@Kommynct
Copy link

reddit has something similar, the top left becomes a link to the subreddit, I found it rather disorienting to not have that, something like that may also be useful, no reason not to have plenty of ways to do this for user-friendliness

const erudaStr = process.env["LEMMY_UI_DEBUG"] ? renderToString(eruda) : "";
let erudaStr = "";

if (process.env["LEMMY_UI_DEBUG"] === "true") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the ternary construction like before, rather than a pointless empty initialization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Updated

@dessalines dessalines merged commit 0d67c64 into LemmyNet:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants