Using auto-generated types from ts-rs. #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #998 - Added support for new `GetFederatedInstances` - Fixed a few bugs in the process.
src/shared/components/app/footer.tsx
Outdated
| @@ -1,6 +1,6 @@ | |||
| import { Component } from "inferno"; | |||
| import { NavLink } from "inferno-router"; | |||
| import { GetSiteResponse } from "lemmy-js-client"; | |||
| import { GetSiteResponse } from "lemmy-js-client/dist/types/GetSiteResponse"; | |||
There was a problem hiding this comment.
Can the types not be imported from just lemmy-js-client?
There was a problem hiding this comment.
@dessalines I made a PR for the js client that should get rid of the need for these individual imports: LemmyNet/lemmy-js-client#118.
There was a problem hiding this comment.
Thanks, I'll make this a draft until I fix up the imports.
SleeplessOne1917
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetFederatedInstancesNotes:
numbertypes tobigint. This is the official type from rust, so it unfortunately added some boilerplate.