Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cantarell instead of Liberation Sans for GNOME users on darkly/darkly-red themes. #779

Closed
IngrownMink4 opened this issue Sep 16, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@IngrownMink4
Copy link
Contributor

Describe the solution you'd like

When I use Lemmy on my computers, the typeface displayed is Liberation Sans on the darkly and darkly-red themes. It is not a bad option per sé, but in Windows the font shown is the one used in the whole operating system (Segoe UI) and it would be nice if the same thing happened with GNOME to ensure that the interface is as consistent as possible and as close to the native interface as possible. For Plasma users it is enough to use Noto Sans too.

The CSS file would look like this:

body {
	font-family: Lato,-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Helvetica Neue", Cantarell, Noto Sans, Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";
	font-size: .9375rem;
	font-weight: 400;
	line-height: 1.5;
	color: #dee2e6;
	text-align: left;
}

Screenshot showing default font
darklywithdefaultfont

Screenshot showing Cantarell font (my proposed change)
darklywithcantarellfont

Describe alternatives you've considered

I am aware that Cantarell is hated by many users and perhaps my wish conflicts with the wishes of other users, so perhaps the best thing would be to let the user choose the one they prefer, using a method similar to what DuckDuckGo does, which is to give a few options to choose from and give the option to indicate a specific font (whatever the user has installed locally).

ddgimplementation

ddgimplementationofcustomfonts

Additional context

The intention of this change is that those of us who use GNOME will feel more comfortable navigating Lemmy, creating a more consistent experience.

@IngrownMink4 IngrownMink4 added the enhancement New feature or request label Sep 16, 2022
@dessalines
Copy link
Member

You can do a PR for this, the themes are in src/assets/css/themes

@IngrownMink4
Copy link
Contributor Author

You can do a PR for this, the themes are in src/assets/css/themes

Okay, I'll try. But do you agree with the proposed changes?

@dessalines
Copy link
Member

Sure, seems fine to me. I'll test this sometime soon.

@IngrownMink4
Copy link
Contributor Author

Hi @dessalines. I noticed that Lemmy.ml does not show the changes from this merge request. Is it an accidental mistake or is there a reason behind this decision not to include it? (In Lemmygrad it is reflected tho).

Captura desde 2023-02-22 18-10-53

Captura desde 2023-02-22 18-11-17

@dessalines
Copy link
Member

Cantarell is there: https://lemmy.ml/css/themes/darkly.css

@IngrownMink4
Copy link
Contributor Author

Cantarell is there: https://lemmy.ml/css/themes/darkly.css

That's weird. I can't see it on Lemmy.ml but I can definitely see it from Lemmygrad.ml without issues. Hmmm, what could be the reason?

@dessalines
Copy link
Member

I'm not sure, and I don't have time to do specific theme work, at least until I auto-generate them from scss files, one of the larger lemmy-ui upcoming tickets.

@IngrownMink4
Copy link
Contributor Author

Hi again Dessalines. It seems that the changes introduced in version 0.18.0 have affected this PR. Can we mark this as "unresolved" again?

Captura desde 2023-07-02 23-22-11

angel-juan-mend pushed a commit to angel-juan-mend/lemmy-ui that referenced this issue Jan 7, 2025
* Adds Cantarell

See: Use Cantarell instead of Liberation Sans for GNOME users on darkly/darkly-red themes. #779 (LemmyNet/lemmy-ui#779)

* Adds Cantarell

See: Use Cantarell instead of Liberation Sans for GNOME users on darkly/darkly-red themes. #779 (LemmyNet/lemmy-ui#779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants