Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme and other settings for logged out users #512

Closed
leslieriver opened this issue Nov 30, 2021 · 2 comments
Closed

Theme and other settings for logged out users #512

leslieriver opened this issue Nov 30, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@leslieriver
Copy link

For backend issues, use lemmy

Is your proposal related to a problem?

logged out users can't change theme or make use of other useful settings.

Describe the solution you'd like

looks like all settings are handled by the api. make use of local storage instead

@leslieriver leslieriver added the enhancement New feature or request label Nov 30, 2021
@dessalines
Copy link
Member

logged out users can't change theme or make use of other useful settings.

This isn't anything I want to support. User settings require a user, and it takes less than a minute to create one and have settings.

looks like all settings are handled by the api. make use of local storage instead

Hard no on this, I intentionally made settings portable, so that they can follow you to whatever device you log in from. I can't stand the localstorage model of having to change your settings for every new browser and device you use.

@leslieriver
Copy link
Author

This isn't anything I want to support. User settings require a user, and it takes less than a minute to create one and have settings.

k. agree for all other settings except theming, there is no reason to force a login to use a preferred theme, it's lemmy-ui specific too so it doesn't really make sense to have it in the api anyway.

Hard no on this, I intentionally made settings portable, so that they can follow you to whatever device you log in from. I can't stand the localstorage model of having to change your settings for every new browser and device you use.

fine, you can add a 'BrowserSettings' alongside it though, there are other settings that make sense to be browser specific like #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants