-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to open links in a new tab #282
Comments
I used to have it that way by default, but it turns out that's a violation of accessibility. I just use middle mouse click now. If anyone wants to add a setting for this tho, go right ahead. |
Me too, but I notice the place where you are supposed to click is a bit finicky, I think it only works when you click on the symbol, not the whole square, do you think that could be changed at least? |
violation of accessibility... Is there a way around this? It is impossible to use the platform if the platform is a link aggregator. We constantly have to go back. Reddit doesn't have this behavior when clicking on links |
I think my previous comment wasn't that concise, so I think except for images, it works great, but when there's a picture and I want to open it in a new tab to download it or whatever, I need to click on this part of the image: Which is all fine and good, but in order to so I have to click exactly in the image icon within the grey box, which is pretty hard, so ideally the whole gray box should be clickable, not only the icon within it. P.S.: Maybe I should open a new issue that's related to image problem and close this one which affects links and cannot be "solved" because it is a violation of accesibility, @dessalines? |
I just tested this out on old reddit, and it does appear to work in the accessible way. New reddit removed the accessibility requirement there. Also, its not difficult to right click -> open in new tab, or middle mouse click.
@LongJohn-Silver Yes you're correct, looks like something is broken there with image posts. I do hijack that clicking to expand within the page itself, so that's probably why, but there's probably a way to fix it. If you could paste your comment into a new issue that'd be helpful. |
On a desktop computer, I agree, but more than 80 % of the traffic comes from a mobile phone. There is no mouse there |
I agree, adding a setting for this would be great. |
On old Reddit it appears to be a setting: preferences => clicking options => open links in a new window. |
Best practice is to never redirect the user away from the site. |
This has been my philosophy since they added the tag to do it. It used to open a new window, until we got tabs. I love that we can open a new site in a tab, and ww can just click back on my site's tab to continue their experience like they never left. It makes things a bit more simple. |
I can't take it anymore. This is so annoying. I might try to make a PR for this. The claims of this being an accessibility feature are unfounded, it goes against the very laws of the internet. The symbol used has clearly come to mean that it's going to be opened in a new tab. EDIT: I haven't gotten around to work on it. |
Would like to add that I'd really like an option for "open links in new tab". It's top of the wishlist for me. |
@krestenlaust please do. The devs are far too busy as it is, I'm sure they'd appreciate it. |
I'm actually working on it as we speak @krestenlaust |
@dogeek any status update on your progress? |
Aaaand it's closed without merge. So disappointing. The workflow of trying to read comments without new tabs is broken:
This is especially annoying when you're a few pages deep and are trying to figure out how to get back there. Automatically opening new comments in tabs would side step this problem. |
I closed it cause I have no interest in having to battle dessalines on minor nitpicks. Feel free to take the branch and reopen the pull request. My thought process was that since lemmy is open source, we should be free to add new features without having to battle over philosophies, which was made apparent to me with his reviews and very strong opinions over which features to greenlight and which features to debate at length over (see infinite scrolling, and this very issue which was only approved on the condition we make it a setting that is off by default). I just don't have the energy to contribute and be challenged on every little thing, I'll just remain a plain user of the platform and not bother contributing to the project anymore. |
Then what's the point of being a LINK aggregator? |
Fixed by #2032 |
I’ve noticed, that links are always being opened in the same tab and after reading you should all the time return to the lemmy page back, which is annoying.
Here is discussion regarding this issue on lemmy: https://lemmy.ml/post/62429
It would be great either to open post's link in a new tab by default or at least have such option in settings.
The text was updated successfully, but these errors were encountered: