Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Saved Posts RSS Using Posts Feed #2438

Closed
5 tasks done
ToffeeIsForClosers opened this issue Apr 24, 2024 · 4 comments
Closed
5 tasks done

[Bug]: Saved Posts RSS Using Posts Feed #2438

ToffeeIsForClosers opened this issue Apr 24, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ToffeeIsForClosers
Copy link

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

Under the Saved (posts) section of a user profile, the RSS feed is not a listing of saved posts but rather the user created posts.

In contrast, the feed under Posts and the feed under Comments both provide their respective RSS article links properly. Based on that setup, it’s reasonable to expect a Saved post RSS feed to be available.

So, either the feed icon should be removed to avoid confusion or, better, an RSS feed for Saved posts should be added.

I am a user, not someone running an instance of Lemmy. I am filing the bug but I won’t be able to support its development or testing at the level that may be expected. Let me know if I shouldn’t log issues here.

Posted to backend Lemmy repo as this handles the RSS, by stated description. Let me know if it should go to
Lemmy-UI.

Steps to Reproduce

  1. Log into Lemmy account and go to Profile > Saved.
  2. Click the RSS button to subscribe/open the feed XML.
  3. Feed is for user-created posts, not the user-saved posts.

Technical Details

My test account was on Lemmy.World. I don’t have the technical details unfortunately.

Version

Not sure

Lemmy Instance URL

lemmy.world

@ToffeeIsForClosers ToffeeIsForClosers added the bug Something isn't working label Apr 24, 2024
@dullbananas
Copy link
Contributor

The icon should be hidden under the saved posts page. This RSS feed would only be useful for saving posts to add them to an RSS feed that you share, and this can already be done by creating a community and crossposting to it. Also, it's risky to make RSS feeds available for private things.

@dessalines this should be moved to lemmy-ui.

@ToffeeIsForClosers
Copy link
Author

ToffeeIsForClosers commented Apr 25, 2024

To offer a counterpoint, I don’t see an RSS of saved public posts any more risky than an RSS of user posts and comments. They’re all based on publicly available content. But perhaps the majority of users may disagree, or maybe I’m not considering the right scenarios.

I’ve used this saved post feature on similar platforms to Lemmy. I’m not sure how they implement it though; if the feed URL is in a standardized format made unique with a username, involves authentication or uses a generated URL that others wouldn’t be able to easily guess.

My use case is more about data liberation than sharing. I want my bookmarked posts and comments to be centrally stored for my reference, not trapped on various platforms. An RSS feed made this easy in past experiences. I’m not sure how to do the same on Lemmy without additional manual steps to export externally every time.

Anyway, some additional context for consideration, fwiw. I’ll be ok if I don’t get my RSS.

@Nutomic Nutomic transferred this issue from LemmyNet/lemmy Apr 25, 2024
@Nutomic
Copy link
Member

Nutomic commented Apr 25, 2024

Saved items are not publicly available through the api, so they also shouldnt be public through other ways as that would be too unexpected.

@dessalines
Copy link
Member

We already have private RSS feeds, for example your subscribed rss feed uses your jwt as part of the RSS url.

So we could add saved posts as its own RSS, but what would be the point? RSS is mainly for news type feeds where you mark new items as read and they get removed, not a bookmarking service.

I think I'm with @dullbananas here, that this is just a lemmy-ui bug (which I'll fix rn), unless there are good arguments made for adding a saved_only RSS feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants