Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nsfw image thumbnail blur-area unintuitively large #1245

Closed
g-rden opened this issue Jun 13, 2023 · 2 comments · Fixed by #1251
Closed

Nsfw image thumbnail blur-area unintuitively large #1245

g-rden opened this issue Jun 13, 2023 · 2 comments · Fixed by #1251
Labels
enhancement New feature or request

Comments

@g-rden
Copy link

g-rden commented Jun 13, 2023

Is your proposal related to a problem?

The clickable area of blurred nsfw thumbnails is smaller than the visible blurred image. This can lead to not clicking the clickable area by mistake.

Describe the solution you'd like.

Expand the clickable area or limit the blurred area to the clickable area. Anyway the two areas should be the same size.

Describe alternatives you've considered.

none

Additional context

No response
@g-rden g-rden added the enhancement New feature or request label Jun 13, 2023
@fheft
Copy link
Contributor

fheft commented Jun 14, 2023

I think limitting the blurred area would be an easy fix using overflow: hidden on the wrapping container:

image

I'll add a PR.

fheft added a commit to fheft/lemmy-ui that referenced this issue Jun 14, 2023
@fheft
Fixed NSFW image blur spilling outside the preview
1477573 
* Hide overflow of wrapping picture element
  to contain the blur of the inner img element.
* This aligns the visible image area to the
  clickable area.
* fixes LemmyNet#1245
@fheft fheft mentioned this issue Jun 14, 2023
Merged
@g-rden
Copy link
Author

g-rden commented Jun 14, 2023

I like it! But sfw images have rounded edges. So nsfw images probably should have those too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed NSFW image blur spilling outside the preview fheft/lemmy-ui
2 participants
@fheft @g-rden