Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long-polling for GetUnreadCounts #1148

Closed
dessalines opened this issue Jun 10, 2023 · 3 comments
Closed

Add long-polling for GetUnreadCounts #1148

dessalines opened this issue Jun 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dessalines
Copy link
Member

After the http merge is complete, we should add long-polling to refetch unread counts.
@dessalines dessalines added the enhancement New feature or request label Jun 10, 2023
@SleeplessOne1917
Copy link
Member

Will this require a change on the backend as well?

@sunaurus
Copy link
Collaborator

Most likely you've already thought of this, but I would like to highlight that it's probably quite important to do any polling only in active tabs, for example using https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState

dessalines added a commit that referenced this issue Jun 14, 2023
@dessalines
Add long-polling to update unread counts in navbar.
10b78ac 
- Fixes #1148
@dessalines
Copy link
Member Author

Its on the navbar component, which has the unread counts.

@sunaurus sunaurus mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dessalines @sunaurus @SleeplessOne1917