Skip to content

Commit

Permalink
fix: Add data-bs-theme attribute for user dark/light modes (#1782)
Browse files Browse the repository at this point in the history
* fix: Add data-bs-theme attribute for user dark/light modes

* fix: Remove unnecessary optional chain

* fix: Oops -- add missing files
  • Loading branch information
jsit authored Jul 4, 2023
1 parent 8730f15 commit b1292b9
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 2 deletions.
16 changes: 14 additions & 2 deletions src/shared/components/app/app.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { isAuthPath, setIsoData } from "@utils/app";
import { dataBsTheme } from "@utils/browser";
import { Component, RefObject, createRef, linkEvent } from "inferno";
import { Provider } from "inferno-i18next-dess";
import { Route, Switch } from "inferno-router";
import { IsoDataOptionalSite } from "../../interfaces";
import { routes } from "../../routes";
import { FirstLoadService, I18NextService } from "../../services";
import { FirstLoadService, I18NextService, UserService } from "../../services";
import AuthGuard from "../common/auth-guard";
import ErrorGuard from "../common/error-guard";
import { ErrorPage } from "./error-page";
Expand All @@ -25,14 +26,25 @@ export class App extends Component<any, any> {
event.preventDefault();
this.mainContentRef.current?.focus();
}

user = UserService.Instance.myUserInfo;

componentDidMount() {
this.setState({ bsTheme: dataBsTheme(this.user) });
}

render() {
const siteRes = this.isoData.site_res;
const siteView = siteRes?.site_view;

return (
<>
<Provider i18next={I18NextService.i18n}>
<div id="app" className="lemmy-site">
<div
id="app"
className="lemmy-site"
data-bs-theme={this.state?.bsTheme}
>
<button
type="button"
className="btn skip-link bg-light position-absolute start-0 z-3"
Expand Down
11 changes: 11 additions & 0 deletions src/shared/utils/browser/data-bs-theme.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import isDark from "./is-dark";

export default function dataBsTheme(user) {
return (isDark() && user?.local_user_view.local_user.theme === "browser") ||
(user &&
["darkly", "darkly-red", "darkly-pureblack"].includes(
user.local_user_view.local_user.theme
))
? "dark"
: "light";
}
4 changes: 4 additions & 0 deletions src/shared/utils/browser/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
import canShare from "./can-share";
import dataBsTheme from "./data-bs-theme";
import isBrowser from "./is-browser";
import isDark from "./is-dark";
import loadCss from "./load-css";
import restoreScrollPosition from "./restore-scroll-position";
import saveScrollPosition from "./save-scroll-position";
import share from "./share";

export {
canShare,
dataBsTheme,
isBrowser,
isDark,
loadCss,
restoreScrollPosition,
saveScrollPosition,
Expand Down
7 changes: 7 additions & 0 deletions src/shared/utils/browser/is-dark.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import isBrowser from "./is-browser";

export default function isDark() {
return (
isBrowser() && window.matchMedia("(prefers-color-scheme: dark)").matches
);
}

0 comments on commit b1292b9

Please sign in to comment.