Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modlog Filters #27

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

makotech222
Copy link
Contributor

@@ -89,6 +89,9 @@
"appoint_as_mod": "appoint as mod",
"leave_mod_team": "leave mod team",
"modlog": "Modlog",
"filter_by_action": "Filter by action",
"filter_by_mod": "Filter by mod",
"filter_by_user": "Filter by user",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pry not necessary, look at the search page and see the i18n strings used there. Type works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree, some languages might use an entirely different word depending on the context, so its better to use specific translation keys.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think using type is fine. Remember that we have limited horizontal space, and it will look like this:

IMG_20220617_130943

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are talking about different things. Using "Type" as the English translation is fine for me. But reusing the same translation key in different places can easily lead to problems, so its better to use seperate ones (even if they happen to be translated identically into English).

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your i18n keys are fine, but the strings used are too long, and aren't going to look great on mobile. I'd just do "type", "creator", and "mod"

@dessalines dessalines merged commit 602683c into LemmyNet:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants